Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e integration tests and isolate tests from other things; includes patch to Serializer #5497

Merged
merged 41 commits into from
Feb 14, 2025
Merged

Improve e2e integration tests and isolate tests from other things; includes patch to Serializer #5497

merged 41 commits into from
Feb 14, 2025

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 11, 2025 •
edited
Loading

removing the dependency between tests and sample projects because that got broken too easily

Why are these changes needed?

  • integration tests used to use the samples - now they are separate
  • patch dictionary problem in serializer
  • add Message Registry with dead letter queue that gets checked on new subs.

Checks

@rysweet rysweet marked this pull request as draft February 11, 2025 21:09
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.07527% with 92 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (3abc022) to head (a61c134).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eway.Grpc/Services/Orleans/MessageRegistryGrain.cs 0.00% 21 Missing and 5 partials ⚠️
...n/RuntimeGateway.Grpc/Services/Grpc/GrpcGateway.cs 0.00% 18 Missing and 4 partials ⚠️
...ation.Tests.AppHosts/HelloAgentTests/HelloAgent.cs 0.00% 16 Missing and 1 partial ⚠️
...y.Grpc/Services/Orleans/Surrogates/AnySurrogate.cs 0.00% 10 Missing ⚠️
...egration.Tests.AppHosts/HelloAgentTests/Program.cs 0.00% 9 Missing and 1 partial ⚠️
....AutoGen/Agents/IOAgent/FileAgent/IHandleFileIO.cs 0.00% 3 Missing ⚠️
...oGen/Agents/IOAgent/ConsoleAgent/IHandleConsole.cs 0.00% 2 Missing ⚠️
...eGateway.Grpc/Abstractions/MessageRegistryState.cs 0.00% 1 Missing ⚠️
...on.Tests.AppHosts/InMemoryTests.AppHost/Program.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5497      +/-   ##
==========================================
- Coverage   78.74%   72.11%   -6.64%     
==========================================
  Files         167      236      +69     
  Lines       10004    11853    +1849     
  Branches        0      230     +230     
==========================================
+ Hits         7878     8548     +670     
- Misses       2126     3128    +1002     
- Partials        0      177     +177
Flag Coverage Δ
unittests 72.11% <1.07%> (-6.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rysweet added 23 commits February 11, 2025 14:32
@rysweet
Merge branch 'main' into rysweet-ensure-helloagent-in-test-uses-grpc
3b967ed
@rysweet
Merge branch 'main' into rysweet-ensure-helloagent-in-test-uses-grpc
ea1a2fc
@rysweet
interim
62bb27e
@rysweet
add dead letter queue.
20bfd1b
@rysweet
interim
90889f2
@rysweet
doh. already had one.
00f0027
@rysweet
test
6d548cb
@rysweet
you have to run AddAgent<>
99a5b90
@rysweet
handle if registration happens before open channel and vice versa
963501b
@rysweet
always add agent type
a00f7fb
@rysweet
important line for running delivery went missing.
279cf22
@rysweet
ensure that we have a connection or write to dead letter until we do.
2259185
@rysweet
we can't throw on unrecognized message type
ab375f7
@rysweet
improving the tests and avoiding a crash if no serialization
b25c4c1
@rysweet
simplify
cd3e8b5
@rysweet
backing off some of my changes to rebase
1190d0e
@rysweet
fixing up sln file afer rebase
d1fd051
@rysweet
Merge branch 'main' into rysweet-ensure-helloagent-in-test-uses-grpc
cb2e89c
@rysweet
format
1d7d4aa
@rysweet
rename the tests to read better
02210ed
@rysweet
rename again
d717745
@rysweet
add in dlq to try and deal with races
f52e436
@rysweet
use the protos from the agents package
6a90016
@rysweet rysweet marked this pull request as ready for review February 13, 2025 22:57
@rysweet rysweet changed the title Rysweet ensure helloagent in test uses grpc Improve e2e integration tests and isolate tests from other things; includes patch to Serializer Feb 14, 2025
lokitoth
lokitoth approved these changes Feb 14, 2025
View reviewed changes
dotnet/samples/Hello/HelloAgent/Program.cs Outdated Show resolved Hide resolved
.../Microsoft.AutoGen.Integration.Tests.AppHosts/HelloAgentTests/Properties/launchSettings.json Outdated Show resolved Hide resolved
python/uv.lock Outdated Show resolved Hide resolved
@rysweet rysweet merged commit ff7f863 into main Feb 14, 2025
53 of 54 checks passed
@rysweet rysweet deleted the rysweet-ensure-helloagent-in-test-uses-grpc branch February 14, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokitoth lokitoth lokitoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rysweet @lokitoth